[0.36.x] Backport clustername and minify helm chart fixes for gme 2.5.x#596
Merged
soloio-bulldozer[bot] merged 8 commits intov0.36.xfrom Apr 22, 2025
Merged
Conversation
…of annotations (#593) * add backwards compatibility in skv2 * add changelog * update skv2 to not fallback to annotations * try backwards compatibility fallback on gets, but not sets * clean up skv2 unit tests * fix changelog * fix issuelink * address nit
|
Issues linked to changelog: |
This reverts commit 341c6c2.
* Don't prettify chart values JSON schema * Changelog * Make linter happy Remove unused functions Add default switch clause * Move changelog * Codegen * Update unit tests assertions * Tests: use `json.Compact` to minify * Un-focus test * Remove unused function # Conflicts: # codegen/test/chart/values.schema.json
jmcguire98
changed the title
marcogschmidt
approved these changes
Apr 22, 2025
birkland
approved these changes
Apr 22, 2025
soloio-bulldozer
Bot
deleted the
jmcguire/backport-clustername-fixes-for-gme-2-5-x
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cluster name fixes:
Description
This updates SetClusterName and GetClusterName to use the generateName field per https://github.com/solo-io/gloo-mesh-enterprise/issues/16342, with GetClusterName maintaining the ability to fallback to annotations or deprecated field names for tooling and testing purposes.
Context
see https://github.com/solo-io/gloo-mesh-enterprise/issues/16342 or https://solo-io-corp.slack.com/archives/C08BL9Z080H for broader discussion
Minify helm chart fixes:
Motivation
With this change, the values.schema.json file generated as part of the Helm chart generation is no longer prettified. This drastically reduces the size of the file and minimizes the changes of the new maximum file size limit introduced by Helm in v3.17.3. There are no functional changes. Human users can still prettify the file using external tools (e.g. jq) if necessary.
Testing
You can test that this fixes the GME issue by following the instructions on https://github.com/solo-io/gloo-mesh-enterprise/pull/20443.